Assume ut_host is supported, and ut_name is not supported #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
UT
branch
from
3b95148 to
53415c8
Compare
Every system we care about has ut_host.
alx@devuan:~/src/musl/libc/master$ grepc -tt utmpx . \
| grep -e '^[.}]' -e ut_host
./include/utmpx.h:struct utmpx {
char ut_host[256];
};
alx@devuan:~/src/musl/libc/master$ cd ../../../bsd/freebsd/main/
alx@devuan:~/src/bsd/freebsd/main$ grepc -tt utmpx . \
| grep -e '^[.}]' -e ut_host
./include/utmpx.h:struct utmpx {
char ut_host[128]; /* Remote hostname. */
char __ut_host[128];
};
./lib/libc/gen/getutxent.3:struct utmpx {
char ut_host[]; /* Remote hostname. */
};
alx@devuan:~/src/bsd/freebsd/main$ cd ../../netbsd/trunk/
alx@devuan:~/src/bsd/netbsd/trunk$ grepc -tt utmpx . \
| grep -e '^[.}]' -e ut_host
./include/utmpx.h:struct utmpx {
char ut_host[_UTX_HOSTSIZE]; /* host name */
};
./lib/libc/gen/endutxent.3:struct utmpx {
char ut_host[_UTX_HOSTSIZE]; /* host name */
};
alx@devuan:~/src/bsd/netbsd/trunk$ cd ../../openbsd/master/
alx@devuan:~/src/bsd/openbsd/master$ grepc -tt utmpx . \
| grep -e '^[.}]' -e ut_host
alx@devuan:~/src/bsd/openbsd/master$ grepc -tt utmp . \
| grep -e '^[.}]' -e ut_host
./include/utmp.h:struct utmp {
char ut_host[UT_HOSTSIZE];
};
./share/man/man5/utmp.5:struct utmp {
char ut_host[UT_HOSTSIZE];
};
alx@devuan:~/src/bsd/openbsd/master$ cd ../../../gnu/glibc/master/
alx@devuan:~/src/gnu/glibc/master$ grepc -tt utmpx . \
| grep -e '^[.}]' -e ut_host
./sysdeps/gnu/bits/utmpx.h:struct utmpx
char ut_host[__UT_HOSTSIZE]
};
./sysdeps/unix/sysv/linux/s390/bits/utmpx.h:struct utmpx
char ut_host[__UT_HOSTSIZE]
};
Signed-off-by: Alejandro Colomar <alx@kernel.org>
ut_name and ut_user can't coexist. We already assume ut_user is supported. Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
UT
branch
from
53415c8 to
92eeb29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some conditional compilation.
Revisions:
v1b
v1c